slbotbm commented on code in PR #2988:
URL: https://github.com/apache/iggy/pull/2988#discussion_r2969608747
##########
foreign/cpp/src/lib.rs:
##########
@@ -81,6 +97,49 @@ mod ffi {
message_expiry_value: u64,
max_topic_size: String,
) -> Result<()>;
+ // fn purge_topic(&self, stream_id: Identifier, topic_id: Identifier)
-> Result<()>;
+ fn create_partitions(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ partitions_count: u32,
+ ) -> Result<()>;
+ fn delete_partitions(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ partitions_count: u32,
+ ) -> Result<()>;
+ fn create_consumer_group(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ name: String,
+ ) -> Result<ConsumerGroupDetails>;
+ fn get_consumer_group(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ group_id: Identifier,
+ ) -> Result<ConsumerGroupDetails>;
+ fn join_consumer_group(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ group_id: Identifier,
+ ) -> Result<()>;
+ fn leave_consumer_group(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ group_id: Identifier,
+ ) -> Result<()>;
+ fn delete_consumer_group(
+ &self,
+ stream_id: Identifier,
+ topic_id: Identifier,
+ group_id: Identifier,
+ ) -> Result<()>;
Review Comment:
creating a `ConsumerGroup` opaque type would force the end user to handle
the clean up for it. I would like to keep the surface area for making a mistake
as small as possible, that is why i did not create another opaque type and a
implementation based on it. Do you think there are any advantages to creating a
`ConsumerGroup` type and its related functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
