slbotbm commented on code in PR #3235: URL: https://github.com/apache/iggy/pull/3235#discussion_r3247083783
########## foreign/php/src/iterator.rs: ########## Review Comment: The iterator does not expose a real iterator in PHP. I think that for a blocking client, if iterator semantics are not required, conversion of all messages to a Vec and giving that to php would be simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
