slash-init commented on PR #3379: URL: https://github.com/apache/iggy/pull/3379#issuecomment-4585509034
> I was doing code review but realized that you are still working on it since github tell me to refresh the PR. However, I do found some problem. I'm sorry when I wrote the misleading proposal since it's just a small silly example. > > I did some small research on it and realized that there is something new about go log system and it would probably help: https://go.dev/blog/slog. I think it can be used directly to replace the `iggcon.Logger` interface. we just need to use `*slog.Logger` as the logger interface, perhaps. Thanks for the clarification. I introduced the interface based on the original proposal, but I agree that using `*slog.Logger` directly would keep things simpler and align with the standard library. I'll update the implementation to use `slog` directly unless you have a different approach in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
