chengxilo commented on code in PR #3379:
URL: https://github.com/apache/iggy/pull/3379#discussion_r3338250730
##########
foreign/go/client/tcp/tcp_core.go:
##########
@@ -203,8 +217,14 @@ func NewIggyTcpClient(options ...Option) *IggyTcpClient {
}
}
+ logger := opts.logger
+ if logger == nil {
+ logger = iggcon.NopLogger()
+ }
Review Comment:
This if statement can be removed. We can just move the default value into
the GetDefaultOptions() at R44.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
