slash-init commented on PR #3379: URL: https://github.com/apache/iggy/pull/3379#issuecomment-4620938556
I removed the custom logger helpers and moved the default logger into `GetDefaultOptions()`. Per Chengxilo's suggestion, I kept the logger parameter mandatory and removed `tcp.WithLogger`, so the TCP client now receives the logger directly and the client and transport always use the same logger. I also added tests covering the logger behavior in both the client and TCP packages as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
