slash-init commented on PR #3379: URL: https://github.com/apache/iggy/pull/3379#issuecomment-4609574281
> I think both logger.go and logger_test.go can be removed. But it doesn't mean we don't need test. Actually, I think it would be great if we can test wither the `WithLogger` works. > > `NopLogger()` can be replaced with `slog.New(slog.DiscardHandler)` directly, very straight forward and easy to understand. Makes sense. If we remove `logger.go` and `logger_test.go`, where would you prefer the replacement tests to live? I was thinking of moving them closer to the actual usage and testing `WithLogger(...)` behavior in the client/TCP tests instead, but wanted to check if that's what you had in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
