mfyuce commented on PR #3516:
URL: https://github.com/apache/iggy/pull/3516#issuecomment-4764439051
All six addressed in this push:
**`task.abort()` without await:** `close()` now takes the handle out of the
mutex first (to release the lock), calls `abort()`, then `let _ = task.await`
to drain the cancelled task before returning. `rx` is also cleared so a
subsequent `open()` after restart passes the already-open guard.
**Log flood / misleading async:** `send_messages` is now a plain `fn` (no
`.await` inside). Drops are counted silently in the loop; a single
`warn!("dropped {dropped}/{total} {signal} messages")` fires once after the
loop.
**Version mismatch:** bumped to `0.4.1-edge.1` to match workspace connector
pattern.
**`opentelemetry-proto` not in workspace:** added to
`[workspace.dependencies]` with `default-features = false`; crate now uses `{
workspace = true, features = [...] }`.
**`pub mod` visibility:** `convert` and `server` narrowed to `pub(crate)`;
only the FFI symbols from `source_connector!` remain public.
**Zero `time_unix_nano` as epoch:** both log records and spans now use
`.then_some()` so proto default `0` maps to `None` instead of `Some(0)`.
/ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
