mfyuce commented on PR #3516: URL: https://github.com/apache/iggy/pull/3516#issuecomment-4763169984
Both addressed in this push: **`resource_attrs` cloned per record/span** — `resource_attrs: Map<String, Value>` is now moved into `Value::Object(resource_attrs)` once before the scope loops; the inner loop clones the `Value` instead of the raw `Map`. The metrics path already passes `resource_attrs` by reference to `metric_to_data_points`, so it was not affected. **`StringValueStrindex` silent drop** — `extract_attrs` now matches `StringValueStrindex` explicitly before calling `any_value_to_json`, which gives access to `kv.key` for the `warn!`. The `any_value_to_json` return path for `StringValueStrindex` (and recursive `KvlistValue` / `ArrayValue` nesting) still returns `Value::Null`; only the top-level attribute key context is logged here. /ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
