hubcio commented on code in PR #3519:
URL: https://github.com/apache/iggy/pull/3519#discussion_r3671794589


##########
.github/config/components.yml:
##########
@@ -513,3 +514,20 @@ components:
       - ".github/actions/**/*.yml"
       - ".github/ci/**/*.yml"
     tasks: ["validate"] # Could run workflow validation
+
+  # gateways are not Rust components, but we want to run them in CI
+  rust-gateway:
+    depends_on:
+      - "rust-sdk"
+      - "rust-workspace"
+      - "ci-infrastructure"
+    paths:
+      - "gateways/**"
+    tasks:
+      - "check"
+      - "fmt"
+      - "clippy"
+      - "sort"
+      - "test-1"
+      - "test-2"
+      - "machete"

Review Comment:
   there is non need to add these tasks because those are already added in 
global rust workspace at line 149



##########
.github/config/components.yml:
##########
@@ -513,3 +514,20 @@ components:
       - ".github/actions/**/*.yml"
       - ".github/ci/**/*.yml"
     tasks: ["validate"] # Could run workflow validation
+
+  # gateways are not Rust components, but we want to run them in CI
+  rust-gateway:
+    depends_on:
+      - "rust-sdk"
+      - "rust-workspace"
+      - "ci-infrastructure"
+    paths:
+      - "gateways/**"
+    tasks:
+      - "check"
+      - "fmt"
+      - "clippy"
+      - "sort"
+      - "test-1"
+      - "test-2"
+      - "machete"

Review Comment:
   there is no need to add these tasks because those are already added in 
global rust workspace at line 149



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to