raviyerraguntla commented on PR #3519: URL: https://github.com/apache/iggy/pull/3519#issuecomment-5151128150
> This PR is quite large, so I've only done a quick pass. Many of the tests look like they were accumulated round by round from review feedback and coverage gap-filling (e.g. review_regression_tests.rs, scope_coverage_tests.rs, region_coverage_tests.rs), with the same behavior often asserted in several suites. I'd suggest reorganizing the tests by subject, roughly: codec, header, request-decode, response-encode, handler, server-e2e. @ethanlin01x - Thank you very much for reviewing. Due to the nature of functionality, there are more lines of test code than actual functional code. This PR handles only the communication part of the interface. As suggested , test code is refactored and "pedantic=warn " and inline imports of crates were removed. Looking forward for another round of review and approval for merger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
