mlevkov commented on PR #3804:
URL: https://github.com/apache/iggy/pull/3804#issuecomment-5161178811
### On the Codecov comment above
It is a snapshot taken before this PR's Rust coverage upload landed, and
Codecov
never re-posted it, so the red X is stuck on the page. Current state from the
Codecov API (`api.codecov.io/api/v2/github/apache/repos/iggy/pulls/3804/`):
```
patch: 94.0% 47 hits / 3 misses / 0 partials
```
All 22 `codecov/*` checks pass, including `codecov/patch`. The comment was
written
at 21:43:36 with the head commit at 7 upload sessions; the 8th landed at
21:43:39
and took the patch figure from 38% to 94%.
**The 3 genuinely uncovered added lines** are the call site in `init()`:
```rust
49 if is_unauthenticated_beyond_loopback(config) {
50 warn!(
54 }
```
The predicate itself has four tests covering the decision table (loopback,
IPv6
loopback, `localhost`, `0.0.0.0`, a routable IP, key configured,
unresolvable),
and dropping its `api_key` early return fails one of them. What is untested
is
that `init()` consults it. Covering that means constructing a
`RuntimeContext` and
binding real listeners to assert a log line was emitted, and it would still
not
catch `init()` dropping the call, since a test of the predicate passes
either way.
Happy to add it if you would rather have the line covered.
**The `-59.11%` project figure is an upload artifact, not a regression.**
This PR
touches only Rust connectors plus docs, so the path-filtered language jobs
resolve
to `noop` in `_detect.yml` and skip. Those languages therefore upload no
coverage
for this head commit, and Codecov scores all of their lines as misses
against a
fully-uploaded base: hits go 120684 to 23540 for a 40-line diff.
`codecov/project`
passes for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
