mlevkov commented on PR #3804: URL: https://github.com/apache/iggy/pull/3804#issuecomment-5229179669
Rebased onto `01a64b2e0` (`b84590a2d`). All five of my open PRs were 35 commits behind, not just this one; the other four are rebased too. No conflicts anywhere, and the full local gate passes on each. **A correction to my earlier comment on this PR.** I explained the `-59.11%` project figure as: > Those languages therefore upload no coverage for this head commit, and Codecov scores all of their lines as misses against a fully-uploaded base. That mechanism is wrong. `codecov.yml` has `flag_management.default_rules.carryforward: true`, and it was already set at the base commit I was describing, so untouched flags should carry their previous report forward rather than count as misses. I found this while reading #3822, whose rationale states the same thing. The observation was real (head project 17.18% against a 75.72% base, hits 120684 to 23540 on a 40-line diff) and `codecov/project` passed throughout, so nothing about the PR changed. But I inferred the cause rather than verifying it, and I would rather flag that than leave a confident wrong explanation in the thread for someone to build on. I do not have a confirmed replacement mechanism and am not going to guess at a second one. Two things from the rebase worth knowing: - #3694 fixed the bash-4 builtins in `scripts/ci/license-headers.sh`, so it now runs on macOS bash 3.2. It passes on all five branches. I had been substituting `hawkeye check` for it locally. - #3822 changed how the master coverage baseline is produced. Post-rebase the patch figure here is unchanged at 0 missed lines. Gate on this branch after the rebase: fmt, sort, clippy `-D warnings`, `cargo test -p iggy-connectors` 129 passing, license-headers, typos, taplo, all exit 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
