hubcio commented on issue #3688: URL: https://github.com/apache/iggy/issues/3688#issuecomment-5172146762
thanks for digging into this. i don't like either option though, both assume we have to take on protoc as a build requirement, and i don't think we do. one correction: prost-build never had a vendored feature (checked 0.11 through 0.14, only format and cleanup-markdown exist). the vendored protoc trick comes from separate crates like protobuf-src or protoc-bin-vendored, which a build script has to use itself. you're still right that we can't fix it from our side, but it shows where the fix belongs. the real problem is upstream. fluss_api.proto is one static file that never changes between builds, so every user of the crate is forced to run codegen for no reason. the normal fix is to commit the generated code into the repo: prost-types does this, and arrow-rs (already a dependency of fluss-rs) commits its generated flatbuffers code with a script to regenerate it. fluss-rs could do the same, or at least use protoc-bin-vendored in its build.rs as a fallback. so let's fix it in apache/fluss-rust instead of working around it here. i don't want everyone who runs cargo clippy --all-features --all-targets to need protoc because of one optional plugin, and exclude creates a crate that misses out on workspace deps, cargo sort, version bumps and ci scoping. would you open an issue there (ideally with the pr, it looks small)? i'll back it on their side. you already showed 0.1.0 works against a 0.9.1 server, so a simple 0.1.1 patch release would unblock us, nothing needed from their main branch. once that ships, the connector comes in as a normal workspace member with zero ci changes. if upstream takes too long, we just wait. on scope: agreed on everything, log tables into Schema::Json first, arrow_ipc later, pk changelog waits for a newer client. hand-rolled test setup is fine. @seokjin0414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
