seokjin0414 commented on issue #3688: URL: https://github.com/apache/iggy/issues/3688#issuecomment-5184975764
You're right about the timeline, thanks for the correction. `vendored` only ever existed up to prost-build 0.10.x (0.10.4 still has the feature, 0.11.0 doesn't), so my "0.14 dropped it" was off by a couple of years. Agreed on fixing this upstream, and it's done on my side: apache/fluss-rust#661 with the PR at apache/fluss-rust#662, following the arrow-flight pattern (checked-in prost output, a small `gen` crate, `regen.sh` for maintainers). - the generated `proto.rs` (1,343 lines) is checked in next to `fluss_api.proto`, byte-identical to what their `build.rs` produces today - `build.rs` and the `prost-build` build-dependency are gone; the `gen` crate depends on prost-build as a normal dependency, so building the workspace never invokes protoc, only running the regeneration does - `cargo build`, `clippy --all-targets --workspace -- -D warnings` and the 572 unit tests pass on a machine with no protoc installed Two things I found on the way: their own CI installs protoc across six workflows (release_python.yml alone has five per-platform install blocks), all of which becomes deletable; and their main has had `check_license_and_formatting` red since Jul 15 because Rust 1.97 clippy flags two `for_kv_map` cases in `accumulator.rs`, so the PR fixes those first to be able to go green at all. Once a 0.1.1 with the fix ships, I'll drop the two protoc commits from #3799 (the CI install and the CONTRIBUTING note) and rebase; the connector and tests themselves don't change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
