hubcio commented on code in PR #3795:
URL: https://github.com/apache/iggy/pull/3795#discussion_r3802996658
##########
core/connectors/runtime/src/source.rs:
##########
@@ -768,3 +944,336 @@ fn build_iggy_message(
(None, None) => IggyMessage::builder().payload(payload.into()).build(),
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use iggy_connector_sdk::ProducedMessage;
+
+ // Prod default (1024) is crossfire's `ArrayMpsc` with `large = true`.
Review Comment:
prod default is 64 now, not 1024. the substance holds - 64 is still
`ArrayMpsc` with `large = true` - but the number is stale.
##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -137,6 +137,8 @@ pub struct CreateSourceConfig {
pub verbose: bool,
#[serde(default)]
pub benchmark: bool,
+ /// Forwarding channel capacity in batches; defaults to 1024.
Review Comment:
still says 1024 - `DEFAULT_CHANNEL_CAPACITY` is 64 and the readme says 64.
same at line 183.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
