mlevkov commented on PR #3795: URL: https://github.com/apache/iggy/pull/3795#issuecomment-5383654975
Closing this per your call on Discord. To leave the reasoning on the record: #3855 retires the premise. One batch is in flight at a time, master's forwarding channel is `flume::unbounded()` so there is no drop path to begin with, and the cursor is persisted only after a successful send. The `dropped` latch here would be defending a drop path that this PR itself introduces. Two things from this work carry forward rather than disappearing with the PR: - The 30s `BATCH_RESULT_TIMEOUT` queue-growth case. You said the timeout stays and Rohan is settling what it was defending against, so I have not filed anything for it. Say the word if you want it tracked once he answers. - A batch that times out and then sends successfully has its Ack refused on the `take_pending_batch` id mismatch, so the runtime logs an error and sets connector error state for a batch that actually shipped. Small, separate, happy to file it. #3899 came out of this review and stays open on its own, since the elasticsearch_source cursor override at open is independent of acks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
