hubcio commented on code in PR #3913:
URL: https://github.com/apache/iggy/pull/3913#discussion_r3806085613
##########
core/sdk/src/clients/consumer.rs:
##########
@@ -297,16 +639,79 @@ impl IggyConsumer {
.await
}
- /// Retrieves the last stored offset (on the server) for the specified
partition ID.
- /// To get the current partition ID use `partition_id()`
+ /// Returns the offset this consumer last stored on the server for the
given partition, or
+ /// `None` if it has not stored one yet.
+ ///
+ /// The value is this consumer's own record of what it committed, kept in
memory rather than
Review Comment:
mayb something like:
"under auto-commit-on-poll (the default) this can trail the server by up to
one batch."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
