hubcio commented on code in PR #3913:
URL: https://github.com/apache/iggy/pull/3913#discussion_r3806095079
##########
core/sdk/src/clients/consumer.rs:
##########
@@ -1207,9 +1702,9 @@ impl IggyConsumer {
);
let client = self.client.read().await;
- // Cleared either way: this consumer is torn down regardless of
- // whether the broker confirmed the leave.
+ // Update consumer state to not being part of a consumer group.
Review Comment:
i think were talkin about different comment, 1707 ("Let the server know...")
was the one that can go. here i just want the old why back: the flag is cleared
even if the leave fails, since the consumer is torn down either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
