ethanlin01x commented on code in PR #3891:
URL: https://github.com/apache/iggy/pull/3891#discussion_r3854119242
##########
core/sdk/src/http/http_client.rs:
##########
@@ -279,7 +279,7 @@ impl HttpClient {
Ok(Self {
api_url,
client,
- heartbeat_interval: IggyDuration::from_str("5s").unwrap(),
+ heartbeat_interval: NonZeroIggyDuration::from_str("5s").unwrap(),
Review Comment:
`HttpClientConfig` now has a `heartbeat_interval` field (default 5s) that is
filled from the connection string, and `HttpClient::create` reads it instead of
hardcoding 5s. Also added a builder setter and a test with
`heartbeat_interval=10s`. Fixed in 7c67c9ad1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
