ethanlin01x commented on code in PR #3891:
URL: https://github.com/apache/iggy/pull/3891#discussion_r3854162810
##########
core/sdk/src/clients/consumer.rs:
##########
@@ -1239,3 +1241,45 @@ impl Drop for IggyConsumer {
);
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use crate::client_wrappers::client_wrapper::ClientWrapper;
+ use crate::clients::consumer_builder::IggyConsumerBuilder;
+ use crate::tcp::tcp_client::TcpClient;
+ use iggy_common::locking::IggyRwLockFn;
+
+ fn builder() -> IggyConsumerBuilder {
+ IggyConsumerBuilder::new(
+ IggyRwLock::new(ClientWrapper::Tcp(TcpClient::default())),
+ "consumer".to_owned(),
+ Consumer::new(Identifier::numeric(1).unwrap()),
+ Identifier::numeric(1).unwrap(),
+ Identifier::numeric(1).unwrap(),
+ None,
+ None,
+ None,
+ )
+ }
+
+ #[tokio::test]
+ async fn should_accept_auto_commit_modes_with_a_zero_interval() {
Review Comment:
The three interval variants of `AutoCommit` now take `NonZeroIggyDuration`,
so a zero interval does not compile any more. Fixed in 62a7fd7e1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
