chengxilo commented on code in PR #3923:
URL: https://github.com/apache/iggy/pull/3923#discussion_r3858814556


##########
core/server/src/bootstrap.rs:
##########
@@ -3030,6 +3040,12 @@ async fn start_tcp_runtime(
     // reactor, so it binds independently. Shard-0 gating comes from the sole
     // caller of this function.
     if let Some(http_addr) = topology.http_listen_addr {
+        // One host for all four transports, resolved from the client-facing
+        // TCP bind so both listeners publish the same node address.
+        let self_advertised = self_advertised_address(

Review Comment:
   Now it will check and warn HTTP/QUIC/Websocket, TCP is not included tho.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to