chengxilo commented on code in PR #3923:
URL: https://github.com/apache/iggy/pull/3923#discussion_r3856921539
##########
helm/charts/iggy/templates/deployment.yaml:
##########
@@ -89,6 +89,14 @@ spec:
name: {{ include "iggy.fullname" . }}-root-credentials
key: password
{{- end }}{{- end}}
+ {{- $declaredInEnv := false }}
+ {{- range .Values.server.env }}
+ {{- if eq .name "IGGY_NODE_ADVERTISED_ADDRESS" }}{{- $declaredInEnv = true
}}{{- end }}
+ {{- end }}
+ {{- if not $declaredInEnv }}
+ - name: IGGY_NODE_ADVERTISED_ADDRESS
Review Comment:
documented, and it will fail whtn both are provided, should be much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
