saie-ch commented on PR #3991:
URL: https://github.com/apache/iggy/pull/3991#issuecomment-5474297295
Thanks for the review @ethanlin01x Could you check now i've addressed the
following
- duration.rs: non-zero durations that round down to 0ms now raise
ValueError instead of silently becoming the zero magic value.
- Corrected the max_idle_timeout docstring to say it falls back to quinn's
30s default, not "no limit".
- max_concurrent_bidi_streams/receive_window now validate against
VarInt::MAX (2^62 - 1), not just u64::MAX.
- initial_mtu now rejects anything below 1200 instead of accepting a value
quinn silently clamps up.
- Same here — added QuicReconnectionConfig(enabled=False) to both tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
