hubcio commented on code in PR #3991:
URL: https://github.com/apache/iggy/pull/3991#discussion_r3892063392
##########
foreign/python/README.md:
##########
@@ -166,6 +166,38 @@ async def main():
await client.connect()
+asyncio.run(main())
+```
+
+`IggyClient.quic(...)` takes a `QuicConfig` the same way, built from
`IggyClient.quic()`'s own
+config type rather than passed to `IggyClient(...)`:
+
+```python
+import asyncio
+from datetime import timedelta
+
+from apache_iggy import AutoLogin, IggyClient, QuicConfig,
QuicReconnectionConfig
+
+
+async def main():
+ client = IggyClient.quic(
+ QuicConfig(
+ server_address="127.0.0.1:8080",
+ server_name="localhost",
+ auto_login=AutoLogin.username_password("iggy", "iggy"),
+ reconnection=QuicReconnectionConfig(
+ enabled=True,
+ max_retries=10,
+ interval=timedelta(seconds=2),
+ reestablish_after=timedelta(seconds=30),
+ ),
+ heartbeat_interval=timedelta(seconds=5),
+ # validate_certificate=True,
+ )
+ )
+ await client.connect()
+
+
Review Comment:
i dont think we need that much code in main README.md for python, remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
