hubcio commented on issue #3982: URL: https://github.com/apache/iggy/issues/3982#issuecomment-5546601424
yeah, let's do it, but scoped the way justin said: keep the forwarding comment, drop the "name every finding before closing" bullet. #3795 to #3981 is a good example. i went and checked the surviving half myself and it holdsup, the nack counter resets on any ack (`source.rs:525`), so the limit never trips on a run that alternates. two things to fix before you write the stale part. the 7-day line is wrong. the bot waits 7 days to label a pr `S-stale`, then another 7 before closing it, so you actually get 14. drafts and anything labeled `pinned` are skipped. and the bot doesn't take its own label back off, two other workflows do that when you push, comment, review, reopen, or mark ready. @justinmclean it can't close issues though, that's switched off in the same file, and the job doesn't even have permission to write to issues. the real part is prs. `pinned` is the only exempt label, so a pr that's waiting on us still gets closed on day 14. worth saying on the dev list: exempting `S-waiting-on-review` won't work, because every non-draft pr gets that label the moment it opens, so the bot would stop doing anything at all. better to flip it around and only stale prs labeled `S-waiting-on-author`, the ones where the ball is in the author's court. either way it's a workflow change, so keep it out of this pr. here's my proposal: ```markdown ## Close Policy PRs may be closed if: - Maintainer feels like proxy between maintainer and LLM - No approved issue or no approval from a maintainer - Code not ran and tested locally - Mixed purposes or purposes not clear - Can't answer questions about the change - Inactivity, see [Stale PRs](#stale-prs) below Whoever closes leaves a comment saying why. If the thread holds a finding that outlives the change, open an issue for it and link it from that comment. The closed thread is the first place someone looks to find out whether anything fell through. ### Stale PRs A bot labels a PR `S-stale` after 7 days without activity and closes it 7 days after that. A push, comment, review, reopen, or ready-for-review clears the label. Drafts and PRs labeled `pinned` are exempt. Issues are never labeled or closed by it. A closed PR can be reopened. ``` can you do that @mlevkov? i assigned issue to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
