yummyPancake2607 commented on code in PR #4020:
URL: https://github.com/apache/iggy/pull/4020#discussion_r3939280138
##########
foreign/python/Cargo.toml:
##########
@@ -38,6 +38,7 @@ doc = false
bytes = "1.12.1"
futures = "0.3.34"
iggy = { path = "../../core/sdk", version = "0.11.0-edge.6" }
+iggy_common = { path = "../../core/common", version = "0.11.0-edge.6" }
Review Comment:
Thank you for the catch! I've dropped the `iggy_common` dependency and
updated the imports in `foreign/python/src/client_info.rs` to re-export types
from `iggy::prelude` instead. The `Cargo.toml` has been updated and all three
types (`ClientInfo`, `ClientInfoDetails`, `ConsumerGroupInfo`) now come through
`iggy::prelude`. This resolves the pinning concern you noted about
`bump-version.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
