yummyPancake2607 commented on code in PR #4020: URL: https://github.com/apache/iggy/pull/4020#discussion_r3939289549
########## foreign/python/src/client_info.rs: ########## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use iggy::prelude::ClientInfoDetails as RustClientInfoDetails; +use iggy_common::{ClientInfo as RustClientInfo, ConsumerGroupInfo as RustConsumerGroupInfo}; +use pyo3::prelude::*; +use pyo3_stub_gen::derive::{gen_stub_pyclass, gen_stub_pymethods}; + +/// Information about a consumer group that a client is part of. +#[gen_stub_pyclass] +#[pyclass] +pub struct ConsumerGroupInfo { + pub(crate) inner: RustConsumerGroupInfo, +} + +impl From<RustConsumerGroupInfo> for ConsumerGroupInfo { Review Comment: I've changed the `From` impl from `From<RustConsumerGroupInfo>` to `From<&RustConsumerGroupInfo>` following the pattern at `consumer.rs:342`. This allows the `consumer_groups` getter to collapse to `.iter().map(ConsumerGroupInfo::from).collect()`, which is cleaner and actually gets called unlike the previous unused impl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
