yummyPancake2607 commented on code in PR #4020:
URL: https://github.com/apache/iggy/pull/4020#discussion_r3939294881
##########
foreign/python/src/client.rs:
##########
@@ -450,6 +451,70 @@ impl IggyClient {
})
}
+ /// Returns information about the currently connected client.
+ ///
+ /// Returns:
+ /// An awaitable that resolves to `ClientInfoDetails`.
+ ///
+ /// Raises:
+ /// RuntimeError: If the request fails.
+
#[gen_stub(override_return_type(type_repr="collections.abc.Awaitable[ClientInfoDetails]",
imports=("collections.abc")))]
+ fn get_me<'a>(&self, py: Python<'a>) -> PyResult<Bound<'a, PyAny>> {
Review Comment:
these three methods sit in the middle of user-management methods while
`ping` and `describe_options` are at the top. I've verified the stub follows
definition order, so reordering them is free and would make the API more
intuitive. I've moved `ping` and `describe_options` closer to `get_me` for
better logical grouping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
