T1B0 commented on PR #4061: URL: https://github.com/apache/iggy/pull/4061#issuecomment-5569590041
thanks for this PR @wangyusheng1985 ! i think we should also include an 'end' event as well since most emitter api consumer rely on it for clean up purpose. Also could you please add an e2e test ? it would be nice to ensure we don't break this feature in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
