spetz commented on code in PR #4061:
URL: https://github.com/apache/iggy/pull/4061#discussion_r3977686919
##########
foreign/node/src/client/client.type.ts:
##########
@@ -65,6 +65,22 @@ export type SendCommandOptions = {
deadline?: number
};
+export type ClientEventMap = {
Review Comment:
The requested `end` event is missing from `ClientEventMap` and is never
emitted. Neither a graceful disconnect nor `client.destroy()` notifies public
listeners of termination. Please add the event and unit and end-to-end coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
