diegomrsantos commented on code in PR #4092:
URL: https://github.com/apache/iggy/pull/4092#discussion_r3982179930
##########
core/shard/src/lib.rs:
##########
@@ -7381,6 +7416,24 @@ where
// spreads over every group instead of replaying the same prefix.
rotate_sweep_to_cursor(namespace_scratch,
self.partition_walk_cursor.get());
+ let mut persistence_metrics =
partitions::PersistenceMetrics::default();
+ for namespace in namespace_scratch.iter() {
Review Comment:
I added a
[regression](https://github.com/diegomrsantos/iggy/commit/76248cf515e9523c4e746bba9d9ded627e306c80)
on top of `7343be420`. It parks a backup acknowledgment, waits for the prepare
to become durable, calls `fence_flush_failure()` while the WAL remains healthy,
and asserts that `drive_persistence()` emits no acknowledgment. It fails on
both Linux and macOS; the existing promotion and deferred purge controls pass.
I’ll work on a focused fix covering the persistence completion and tick
paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
