hubcio commented on code in PR #4193:
URL: https://github.com/apache/iggy/pull/4193#discussion_r4016282800
##########
core/message_bus/src/installer/replica.rs:
##########
@@ -369,8 +369,6 @@ pub fn install_replica_conn<C: TransportConn>(
// `notify_connection_lost` stands down whenever a live registry entry
// exists - but the loser also drives `replica_dispatch_loop`, which
// must never hand the winner's replica id to `on_message`.
- // `compio::runtime::JoinHandle::drop` does not cancel the spawned
- // task, so we have to tell the tasks to stand down in-band.
let install_aborted = Rc::new(Cell::new(false));
Review Comment:
the preceding comment still explains why losing tasks must not dispatch
using the winner's replica ID. only the incorrect claim that dropping a
`JoinHandle` does not cancel its task was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
