justinmclean commented on PR #4218: URL: https://github.com/apache/iggy/pull/4218#issuecomment-5723586803
Thanks @kunaldevxxx for this PR. I ran the validator tests on your branch and all 53 passed, so that behaviour looks to be unchanged. The warning(s) reach the log. A few things before a more thorough review: - Please fill in the PR template. Add Closes #4209 and complete the Local Execution and AI Usage sections. The template says PRs that don't show the code was run locally can be closed. - The three loopback tests only check that validation returns Ok, which it already did before this change. They pass whether or not the warning fires. - given_missing_container_indicators_when_checking_container_should_return_false still reads container and KUBERNETES_SERVICE_HOST from the real environment, so it would fail if the tests ran inside a pod. Passing those values in, as you do with the paths, would fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
