hubcio commented on PR #4218:
URL: https://github.com/apache/iggy/pull/4218#issuecomment-5728406517

   two notes outside the diff.
   
   `core/server/README.md:15` is true of the repo-root `Dockerfile:45-48`, 
where `docker compose up` sets `IGGY_*_ADDRESS=0.0.0.0`. `apache/iggy` builds 
from `core/server/Dockerfile`, which sets no addresses and ships no 
`config.toml`, so the published image boots on the embedded default and binds 
`127.0.0.1` on all four listeners. the documented `docker run -p 8090:8090 ... 
-e IGGY_NODE_ADVERTISED_ADDRESS=localhost` is exactly this warning case, and it 
boots with a warning instead of a refusal.
   
   dropping the `advertised_address` shortcut means the websocket, quic and 
http addresses are now parsed at validation instead of boot. both stages 
refuse, so a note in the commit body is enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to