hubcio commented on PR #4249:
URL: https://github.com/apache/iggy/pull/4249#issuecomment-5795546046

   thanks @haubur! I saw the `consumer_group` and connectors gate fixes, will 
review again
   
   1. fine by me, just link the docs PR here so the nits don't get lost.
   2. separate PR please. it's not introduced here: the http client sends ids 
through `as_cow_str()`, and the server parses path ids with `from_str_value()`, 
which tries `u32` first. so a digit-only name becomes a numeric id on any HTTP 
call, not only in the stream builder.fixing it changes how the HTTP API reads 
IDs so an issue with a repro first would be great. happy to review whatever you 
come up with


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to