haubur commented on PR #4249: URL: https://github.com/apache/iggy/pull/4249#issuecomment-5793814919
@hubcio thanks! I updated the PR. Two things: 1. The doc nits will land with the IggyStream docs PR if that is okay 2. The warning on HTTP should maybe not just be a note but properly fixed. I had a look at it and the problem seems to be that currently, there is no way to properly send an `IdKind`. The id goes through `Identifier::as_cow_str()` where the kind of identifier is lost and only the value reaches the server, then being cast back to `Identifier` via `Identifier::from_str_value()` on the server side. Should a fix land in this PR or is another fine as well? Would take a closer look and come up with a solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
