ryerraguntla commented on code in PR #4258: URL: https://github.com/apache/iggy/pull/4258#discussion_r4093421019
########## gateways/kafka/README.md: ########## @@ -2,13 +2,15 @@ Foundation layer for [apache/iggy#3421](https://github.com/apache/iggy/issues/3421): a TCP listener on the Kafka wire port that decodes requests, validates scoped API keys and versions, and returns stub responses. -> **Stub warning:** most APIs still don't persist or read real data. Produce and Fetch return -> retriable `NOT_LEADER_OR_FOLLOWER` (6) so clients keep data locally / retry elsewhere instead of -> trusting a fake success. CreateTopics does **not** create topics; valid requests return -> `NOT_CONTROLLER` (41). Metadata still reports requested topics as unknown. ListOffsets is wired -> to the Iggy bridge: with `IGGY_KAFKA_BRIDGE_ENABLED=true` it answers `EARLIEST`/`LATEST` from -> real partition state; with the bridge off (the default) it stays a stub and answers -> `NOT_LEADER_OR_FOLLOWER` (6). See [docs/SCOPE.md](docs/SCOPE.md). +> **Stub warning:** Produce, Fetch, and ListOffsets still don't persist or read real data - they Review Comment: Fixed, and root-caused: 20d323793 (#4259) added the correct ListOffsets sentence to this paragraph, but a later doc-only commit (dafcba827) overwrote the whole paragraph back to older wording and a merge conflict resolution kept that older version, silently dropping #4259's addition. Rewrote the paragraph to include all three pieces of accurate status (Produce/Fetch stub, CreateTopics/Metadata bridge-wired, ListOffsets bridge-wired) in one coherent statement instead of just re-inserting the dropped sentence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
