mattp5657 commented on PR #3873: URL: https://github.com/apache/iggy/pull/3873#issuecomment-5848596216
@slbotbm Thank you for review! I found a couple more things while going but please let me know if you have any more comments. Summary of additional changes: - Contradictory bulk item (2xx + error) was reported as permanent failure instead of retried on one path — now retried (idempotent by `_id`). - `Retry-After` header had no upper bound — now clamped to `max_retry_delay`. - Added a test verifying `refresh` actually reaches the request, not just the config resolution. - Replaced a hand-rolled bulk-response deserializer with a derived struct — smaller, and fixes a key-order parse bug. - Minor: incorrect comment, missing connector ID in one log line, redundant header string clone, one test name fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
