mattp5657 commented on PR #3873: URL: https://github.com/apache/iggy/pull/3873#issuecomment-6019337361
1. **Fixed:** `lib.rs:470`, Proto dropped. Now indexed as JSON or text, with unit and integration tests. 2. **Deferred:** `lib.rs:464`, deep copy. Waiting on #4399, then a one-line swap. 3. **Fixed:** `lib.rs:839`, warning spam. Warns once per instance, still counts drops. 4. **Fixed:** `lib.rs:229`, `timeout = "0s"`. Clamped to 1s. 5. **Fixed:** `lib.rs:98`, comment. Names `serialize_secret`. 6. **Fixed:** `lib.rs:799`, `verbose_logging`. One `log_progress!` macro. 7. **Fixed:** `lib.rs:1309`, tuple hash. IDs unchanged, pinned by a test. 8. **Skipped:** `lib.rs:846`, `preparation_errors`. The compiler needs the catch-all arm anyway. 9. **Fixed:** `lib.rs:1455`, `sanitize_url_for_log`. Deleted. 10. **Fixed:** `README:179`, `/stats`. Says the counter rises per failed run. 11. **Skipped:** `Cargo.toml:20`, version. Keeping `0.5.0-edge.4` as requested by slbotbm. 12. **Fixed:** `Cargo.toml:49`, lints. Added `[lints] workspace = true`. 13. **Fixed:** `opensearch_sink_failures:52`, doc and assertion. Corrected, and the test asserts `errors == 1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
