theluckystrike opened a new pull request, #4332: URL: https://github.com/apache/iggy/pull/4332
Fixes #4331 Implements the GetSnapshot binary command (code 11) in the Node SDK, following the existing `getStats.command.ts` pattern as suggested in the issue. **Serialize** (matches `core/binary_protocol/src/requests/system/get_snapshot.rs`): - marker byte `7` - `u32` stream_id (kind byte + value), `u32` partition_id, `u64` start_offset, `u32` count - `u8` snapshot_types_count + one `u8` per type - matches the Rust `roundtrip_empty_types` test case: an empty `snapshot_types` list is valid, so no client-side min-length check **Deserialize** (matches `.../responses/system/get_snapshot.rs`): - `u32` length + raw ZIP bytes, passed through to the caller Also exports the command from the system wire index and wires `getSnapshot` into the client's `system` API surface. Validation: `npx tsc --noEmit` clean on the `foreign/node` package. Signed-off-by: theluckystrike <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
