krishvishal commented on code in PR #4392:
URL: https://github.com/apache/iggy/pull/4392#discussion_r4186241452
##########
core/common/src/types/consumer/consumer_kind.rs:
##########
@@ -88,15 +91,55 @@ impl Consumer {
id,
}
}
+
+ /// Creates a new `ExternalGroup` from the `Identifier` of an Iggy
consumer group.
Review Comment:
Fixed: the docs of `Consumer::external_group`, `ConsumerOffsetClient` and
`MessageClient::poll_messages` name `FeatureUnavailable`.
##########
core/partitions/src/iggy_partition.rs:
##########
@@ -752,8 +747,9 @@ where
/// Set the per-kind durable consumer-offset limit for this partition.
pub fn set_consumer_offsets_max(&mut self, offsets_max: usize) {
- self.consumer_offset_capacity.set_limit(offsets_max);
- self.consumer_group_offset_capacity.set_limit(offsets_max);
+ for capacity in &self.consumer_offset_capacities {
+ capacity.set_limit(offsets_max);
Review Comment:
Fixed: the `consumer_offsets_max` comment in `config.toml` counts external
groups as a third kind.
##########
core/integration/tests/server/cg.rs:
##########
@@ -81,6 +81,14 @@ async fn offset_cleanup(harness: &TestHarness) {
consumer_group_offset_cleanup_scenario::run(harness).await;
}
+#[iggy_harness(
+ test_client_transport = [Tcp, WebSocket, Quic],
Review Comment:
Fixed: a unit test covers all four HTTP client methods, and a CLI test sets
an offset with `--kind external-group` and reads it back.
##########
core/partitions/src/partition_storage.rs:
##########
@@ -798,7 +838,11 @@ async fn load_partition_consumer_group_offsets<S:
DurableStorage>(
Ok(RecoveredOffsets::default())
}
Err(source) => Err(PartitionRecoveryError::ConsumerOffsetsLoad {
- consumer_kind: "consumer group",
+ consumer_kind: if kind == ConsumerKind::ExternalGroup {
Review Comment:
Fixed: the error labels use `kind.as_str()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
