krishvishal commented on code in PR #4392:
URL: https://github.com/apache/iggy/pull/4392#discussion_r4186240545
##########
core/partitions/src/iggy_partition.rs:
##########
@@ -1106,14 +1095,8 @@ where
}
}
}
- let mut directories = Vec::with_capacity(4);
- for directory in [
- &self.consumer_offsets_path,
- &self.consumer_group_offsets_path,
- ]
- .into_iter()
- .flatten()
- {
+ let mut directories = Vec::with_capacity(ConsumerKind::COUNT + 2);
+ for directory in self.consumer_offset_dirs.iter().flatten() {
Review Comment:
Not fixed, on purpose: a delete leaves the dirty set, so skipping the
directory can lose an unsynced unlink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
