tusharagrahari commented on code in PR #3568: URL: https://github.com/apache/iggy/pull/3568#discussion_r4187441046
########## core/connectors/sources/mysql_source/Cargo.toml: ########## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +name = "iggy_connector_mysql_source" +version = "0.1.0" +description = "Iggy MySQL source connector supporting table polling for message streaming platform" +edition = "2024" +license = "Apache-2.0" +keywords = ["iggy", "messaging", "streaming", "mysql", "polling"] +categories = ["command-line-utilities", "database", "network-programming"] +homepage = "https://iggy.apache.org"; +documentation = "https://iggy.apache.org/docs"; +repository = "https://github.com/apache/iggy"; +readme = "README.md" +publish = false + +[package.metadata.cargo-machete] +ignored = ["dashmap"] + +[lib] +crate-type = ["cdylib", "lib"] + +[dependencies] +async-trait = { workspace = true } +base64 = { workspace = true } +chrono = { workspace = true } +dashmap = { workspace = true } +humantime = { workspace = true } +iggy_common = { workspace = true } +iggy_connector_sdk = { workspace = true } +rust_decimal = "=1.42.1" Review Comment: Fixed by the Ack staging. Delete/mark no longer runs in poll(). It runs in on_batch_result after Ack. A failed cleanup stays pending, and while anything is pending poll() always takes the pacing sleep and returns an empty batch without running the SELECT. So a persistent cleanup failure no longer re-reads or decodes rows. After 3 consecutive cleanup failures the connector stops, and the staged cleanup stays in the saved state to run again on restart. also fixed the rust_decimal Fixed. rust_decimal is now declared in [workspace.dependencies] and the crate uses { workspace = true }, so mysql_source has no non-workspace dependencies left. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
