FenjuFu commented on PR #4357:
URL: https://github.com/apache/iggy/pull/4357#issuecomment-6055233451

   Thanks for the review. I rebased on master and pushed the changes:
   
   - inlined the test helpers
   - the zero-count test now waits for the reconciler before asserting
   - out-of-range int identifiers are documented and tested as `TypeError`
   - the docstring explains that a held-back deletion finishes later
   
   I ran `prek` on both commits and the `sdk-python` lint and test jobs on my 
fork (857 passed, including the 18 segment tests).
   
   /ready


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to