Mola-maker commented on PR #4478: URL: https://github.com/apache/iggy/pull/4478#issuecomment-6131189170
Thanks for the review, @hubcio. Fixed in d79d640: both CLI harness entry points in core/integration/tests/cli/common/mod.rs (the test-case runner and the help-command path) now set IGGY_TOKEN to an empty value before applying each case's own environment, so an ambient token inherited from the test process can no longer override the username/password credentials a case sets up. Cases that exercise token auth set their own IGGY_TOKEN in their environment, which is applied afterwards and still wins, and the CLI already treats an empty token as unset. Verified locally: cargo fmt --all -- --check clean, cargo clippy -p integration --all-targets -- -D warnings clean, cargo test -p iggy-cli 87 passed, prek run passes. The live-server login integration tests cannot run in my sandbox (io_uring is blocked there), so those are left to CI as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
