hubcio commented on code in PR #4478:
URL: https://github.com/apache/iggy/pull/4478#discussion_r4255544022
##########
core/cli/src/args/mod.rs:
##########
@@ -96,19 +96,28 @@ pub(crate) struct CliOptions {
pub(crate) debug: Option<PathBuf>,
/// Iggy server username
- #[clap(short, long, group = "credentials")]
+ ///
+ /// Can also be provided with the IGGY_USERNAME environment variable.
+ #[clap(short, long, group = "credentials", verbatim_doc_comment)]
pub(crate) username: Option<String>,
/// Iggy server password
///
/// An optional parameter to specify the password for authentication.
/// If not provided, user will be prompted interactively to enter the
/// password securely.
+ ///
+ /// Can also be provided with the IGGY_PASSWORD environment variable.
Review Comment:
warning: this help suggests `IGGY_PASSWORD` works with `--username`, but
that combination reads stdin. document that `IGGY_USERNAME` and `IGGY_PASSWORD`
only work as a complete environment pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
