Arham-Begani commented on PR #4552: URL: https://github.com/apache/iggy/pull/4552#issuecomment-6184403145
Hi! I’d like to work on this. I got ahead of myself and opened #4552 before being assigned, which the bot closed. Sorry about that. @dajneem23 offered back in April, so I’m happy to step back if they’re still on it. #4552 adds typed on/once to Client for connecting, connected, error and end, as T1B0 and spetz asked for on #4061. end fires once after destroy(), and error is only re-emitted when someone listens. It includes unit tests and an e2e test. A few questions before it goes further: 1. Is it OK to also add off/removeListener? Without them a listener can’t be removed, and events.once(client, ...) breaks. 2. Should disconnected be included? The internal event also fires for dials that never connected, so it needs agreed rules first. Should it go in this PR or a follow-up? 3. Should eviction go in this set of events, or is it better as a separate session event? 4. I noticed reconnect maxRetries exceeded is emitted twice for one outage. Would you like a separate issue for that? If the approach looks fine, could you assign me? I’ll reopen or open a new PR from the same branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
