Arham-Begani commented on code in PR #4552:
URL: https://github.com/apache/iggy/pull/4552#discussion_r4285138385
##########
foreign/node/src/client/client.type.ts:
##########
@@ -74,6 +74,20 @@ export type SendCommandOptions = {
context?: PartitionContext
};
+/**
+ * Connection lifecycle events of a `Client`, with their listener arguments.
+ */
+export type ClientEventMap = {
+ /** A dial to the server starts: the first one, a redial or a redirect */
+ connecting: [],
+ /** The dialed socket is ready: TCP connected, or TLS handshake done */
+ connected: [],
+ /** The connection reported an error, such as a failed dial */
+ error: [error: Error],
+ /** `destroy()` closed the connection. No event follows this one */
Review Comment:
Fixed in b79775b: redirect() now rejects with connection is closed once the
connection is ending, like connect(). Added a test that destroys, then
redirects, and checks that nothing is dialed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
