choksi2212 commented on PR #4497: URL: https://github.com/apache/iggy/pull/4497#issuecomment-6285406763
Rebased onto current `master` (was 24 commits behind, including the two breaking `foreign/go` changes in #4550 and #4561), so the branch stays mergeable while awaiting the re-review. The single conflict was in `tcp_core.go`: master restructured that region for partition routing, so I took master's side wholesale and re-grafted `GetNoDelay()` after `GetConnectionInfo`, keeping the parsed nodelay option observable before the first connection. Everything else merged clean, including the connection-string parser and its tests. Verified on the merge result (`480d4fd7`): - `go test ./client/... ./internal/vsr/...` — all green, including the 11 connection-string tests and the VSR protocol-parity suite against the new Rust enums - `go vet ./...` — clean - `gofmt` — clean - `git diff master...feat/go-connection-string-4491` is exactly the five files of this PR again, so the merge drops none of master's partition-routing work The five review points from the `/ready` summary are unchanged by the rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
