choksi2212 commented on PR #4497: URL: https://github.com/apache/iggy/pull/4497#issuecomment-6402665518
Merged current `master` (through `6ce2f92a`, the #4571 refactor wave) into this branch so the review isn't against a stale base. The only textual conflict was the import block in `tcp_connect_test.go`: the cert-minting helper delegation to `fakevsr` is kept, and `fmt`/`strings` are added for the new silent sign-in tests. `tcp_core.go` and `tcp_testing_test.go` auto-merged cleanly against the new `markBound`/`hasRoster` internals. Verified on the merge result: - `go build ./...` clean, `go vet` clean on `client` + `internal/fakevsr` - connection-string suite green in every run (`TestParseConnectionString_*`, all 14) - full `client` package green; full `client/tcp` suite green on a clean run One honest caveat about the tcp suite on my local box: across five full-package runs it intermittently failed three *different* tests (`TestDriverAfterSilentMetadataReplicaDiscoversThroughAnotherLink`, `TestPrimaryPoll_InvalidBindingDoesNotPollAndRetiresConnection`, and on pristine `master` `TestSessionRecovery_StopsOnDisconnectOrClose`). Each passes deterministically when re-run, and pristine `master` flakes there too, so it is contention on my machine rather than anything this branch introduces - the `TestDriverAfterSilent...` failure I saw on the first run reproduced at 0.01s and never again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
